Skip to content

Conversation

@rht
Copy link
Contributor

@rht rht commented Jul 8, 2024

No description provided.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@rht
Copy link
Contributor Author

rht commented Jul 8, 2024

I'm not sure about including the .png this early, because we are going to do lots of iterations on the code anyway. I will delete it once this PR is approved.

@adamamer20
Copy link
Member

adamamer20 commented Jul 9, 2024

I don't know why polars native has an initial spike. Maybe it's related to caching?

I'm not sure about including the .png this early, because we are going to do lots of iterations on the code anyway. I will delete it once this PR is approved.

OK for me.

@adamamer20 adamamer20 merged commit a70b39e into main Jul 9, 2024
@adamamer20 adamamer20 deleted the benchmark branch July 9, 2024 10:07
@rht
Copy link
Contributor Author

rht commented Jul 9, 2024

I can't reproduce the Polars spikes in your plot. This is what it looks like on main after you have merged this PR and I have pulled from upstream main:
readme_plot_2

Polars version: 1.1.0
Python: 3.11

@adamamer20
Copy link
Member

Then it's probably related to perfplot on my laptop. I noticed that with a less powerful CPU and less RAM the collected time becomes more unstable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants